-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise VS Code API level to 1.68.1. #12090
Raise VS Code API level to 1.68.1. #12090
Conversation
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new version is consistent with the current tracking of supported VS Code APIs.
I've come in too late here, but I'd like to add a few cents, nevertheless. I have misgivings about lifting the default supported API to a level that includes code we know to be stubbed. As an application developer, I would not want users downloading plugins when I don't know how stubbed API is actually being used. Much of the stubbed API is fairly self-contained - Test API, Notebook API - so there's a good chance that those stubs won't interfere with functionality the user is accustomed to, but other pieces are not so isolated. For example, if a plugin switches from the So I wonder whether, with the advent of stubbing, we should introduce different concepts of compatibility. In the context of Open VSX, the lower level - real support - could be used for the default download and the higher level - subbed support - for the 'Install another version command,' so that users can be held responsible for their decision there. |
@colin-grant-work stubbing and how to advertise it a very good topic, but not for a comment on a PR: this needs to be raised on the mailing list and maybe in a community call if it's a problem. If this rubs you the wrong way, we should talk about it. In the end, this is about enabling adopters (which your group is), not us looking good in a report. |
…2090) Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
…2090) Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
What it does
Fixes #12029
Contributed on behalf of STMicroelectronics
How to test
./plugins
.yarn download:plugins
Review checklist
Reminder for reviewers