Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monaco: improve responsiveness of quick-input menus #12095

Merged
merged 1 commit into from
Jan 26, 2023
Merged

monaco: improve responsiveness of quick-input menus #12095

merged 1 commit into from
Jan 26, 2023

Conversation

FernandoAscencio
Copy link
Contributor

@FernandoAscencio FernandoAscencio commented Jan 20, 2023 •
edited by vince-fugnitto
Loading

What it does

The pull-request fixes an issue where the monaco quick-input menus are not responsive and do not display properly when the application is resized. The changes fix a bug when setting the layout of the monaco container to be aware of the client's width and height (which was previously incorrectly hardcoded), and notify the container when the layout is updated. The change also removes hardcoded width and margin and instead lets monaco handle the display.

quick-input-resize.mov

How to test

  1. start the application
  2. open the command palette (F1)
  3. confirm the display is correct
  4. resize the window and confirm the quick-input menu is resized
  5. repeat the steps with other menus
  6. repeat the steps with the application starting at different window sizes

Review checklist

Reminder for reviewers

Signed-off-by: FernandoAscencio fernando.ascencio.cama@ericsson.com

@vince-fugnitto vince-fugnitto marked this pull request as draft January 22, 2023 21:02
@FernandoAscencio FernandoAscencio changed the title style: quick input box fix 1/2 style: quick input widget size fix Jan 24, 2023
@FernandoAscencio FernandoAscencio force-pushed the fa/QuickInputBoxFix branch 4 times, most recently from db315fa to c19b5de Compare January 24, 2023 21:34
@FernandoAscencio
style: quick input widget size fix
8314124 
This commit implements quick-input-widget size change with respect to app size, as well as handling text overflow resulting from this.

There are issues regarding specific cases with the overflow handling.

Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vince-fugnitto vince-fugnitto marked this pull request as ready for review January 26, 2023 13:19
@vince-fugnitto vince-fugnitto added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Jan 26, 2023
@vince-fugnitto vince-fugnitto requested a review from msujew January 26, 2023 13:19
@vince-fugnitto vince-fugnitto changed the title style: quick input widget size fix monaco: improve responsiveness of quick-input menus Jan 26, 2023
msujew
msujew approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I can confirm that the issue exists on master and is nicely addressed by this change. Looks exactly like in vscode now :)

@msujew msujew merged commit 105a24e into eclipse-theia:master Jan 26, 2023
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Feb 2, 2023
@FernandoAscencio
monaco: quick input menu start debugging
5cb970b 
Fixes a regression brought by eclipse-theia#12095 in the debug menu.

Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vnfedotov vnfedotov mentioned this pull request Feb 14, 2023
Closed
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Feb 15, 2023
@FernandoAscencio
monaco: quick input menu start debugging
9d6d537 
Fixes a regression brought by eclipse-theia#12095 in the debug menu.

Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Feb 22, 2023
@FernandoAscencio
monaco: quick input regression fix
2bca18e 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@FernandoAscencio FernandoAscencio mentioned this pull request Feb 22, 2023
Closed
1 task
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Feb 23, 2023
@FernandoAscencio
monaco: quick input regression fix
5ce3db9 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Feb 23, 2023
@FernandoAscencio
monaco: quick input regression fix
68fe499 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
This was referenced Feb 23, 2023
Closed
Merged
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 2, 2023
@FernandoAscencio
monaco: quick input regression fix
885bd0d 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 2, 2023
@FernandoAscencio
monaco: quick input regression fix
c8e7032 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 2, 2023
@FernandoAscencio
monaco: quick input regression fix
79579c7 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 2, 2023
@FernandoAscencio
monaco: quick input regression fix
0d7b6ff 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 3, 2023
@FernandoAscencio
Quick Input: Rollback overflow handling
2d0fa25 
This commit undoes the overflow handling introduced in eclipse-theia#12095.
The overflow handling is the main culprit in several alignment issues

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 3, 2023
@FernandoAscencio
monaco: quick input regression fix
b2aa32a 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 8, 2023
@FernandoAscencio
monaco: quick input regression fix
94eaf02 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 21, 2023
@FernandoAscencio
monaco: quick input regression fix
ee07fb0 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 29, 2023
@FernandoAscencio
monaco: quick input regression fix
005c21b 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request Mar 31, 2023
@FernandoAscencio
monaco: quick input regression fix
225d284 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this pull request May 31, 2023
@FernandoAscencio
monaco: quick input regression fix
a550ba7 
This commit is the first attempt to fix the regression introduced in
 eclipse-theia#12095

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FernandoAscencio @msujew @vince-fugnitto