Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DocumentDropEditProvider (#12025) #12125

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Jan 30, 2023

What it does

resolves #12025
this implements the vscode extension api for

  • DocumentDropEdit
  • DocumentDropEditProvider
  • as well as the corresponding registration method in the language namespace

also implments DTOs including converters and ability to resolve the file Data for those for #11776.

How to test

here is a small test extension:
documentdropedit-test-0.0.1.zip

or you can build it here:
https://github.com/jonah-iden/documentdropedit-test

  1. install extension
  2. execute "Register dropEdit provider"
  3. drop one or multiple fils into editor
  4. should see messages with name of each file and content of one file should have been added to current cursor position in the editor

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
(still need to access filesystem in adapter though)

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@msujew msujew changed the title Jiden/vscode support documentdropeditprovider 12025 Support DocumentDropEditProvider (#12025) Jan 30, 2023
@msujew msujew added the vscode issues related to VSCode compatibility label Jan 30, 2023
@msujew msujew self-requested a review February 7, 2023 15:12
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@JonasHelming
Copy link
Contributor

@jonah-iden @msujew : What is the state of this PR?

@jonah-iden
Copy link
Contributor Author

I have applied all suggested review changes. So if there aren't any other comments this could be merged

@msujew msujew self-requested a review February 13, 2023 11:24
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the changes, looks good to me 👍

  • The sample extension works as expected with the new API
  • The inversion of file system <-> language services plugin dependencies works as well
  • The comparator status report marks the API as fully supported

I'll merge this PR in the coming days, if there are no objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support DocumentDropEditProvider and DocumentDropEdit
4 participants