Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script for downloading debug adapters #12150

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 6, 2023

What it does

Closes #8713

The script in question seems to be unused, as it was used to download debug adapters for the java-debug package which was removed a few years ago. The script itself doesn't do a lot and can be easily replicated on user site using the RequestService if necessary.

How to test

There's nothing to test really, it mostly cleans up a few dependencies which were purely used inside of this script.

Review checklist

Reminder for reviewers

@msujew msujew added the dependencies pull requests that update a dependency file label Feb 6, 2023
@vince-fugnitto
Copy link
Member

I believe it fixes #8713 :)

@msujew
Copy link
Member Author

msujew commented Feb 6, 2023

@vince-fugnitto Indeed :)

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paul-marechal paul-marechal merged commit 2e213c8 into master Feb 6, 2023
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 6, 2023
@msujew msujew deleted the msujew/remove-download-adapters branch February 6, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quality: remove 'download-debug-adapters' script
3 participants