Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickInput: First Element Fallback on Enter #12208

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

FernandoAscencio
Copy link
Contributor

@FernandoAscencio FernandoAscencio commented Feb 22, 2023

What it does

Closes #11979

How to test

  1. Run Theia
  2. Open as a many quick input menus as you can think of
  3. Check that the first item on each of them is highlighted unless there is an active setting such as Dark (Theia) theme.

Some example menus that have been tested:

  1. ? or the help menu
  2. > or the command menu
  3. F5 on Attach By Process ID
  4. Quick checkout menu in the status bar
  5. New Terminal (With Profile)... menu
  6. Ctrl+K, Ctrl+T or the Color Theme menu.
  7. File Icon Theme menu.
  8. This plugin.
  9. Using the Internal QuickPick command added in this request.

QuickInputFirstItemFocusFinal

Review checklist

Reminder for reviewers

Signed-Off-By: FernandoAscencio fernando.ascencio.cama@ericsson.com

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I can confirm that the first element is always selected in case there's no explicit selection made programmatically.

@msujew
Copy link
Member

msujew commented Mar 2, 2023

@FernandoAscencio Before I merge this PR, do you mind rebasing your PR onto the latest master? Just to confirm that your changes aren't the reason that the Ubuntu build pipeline is failing.

@FernandoAscencio
Copy link
Contributor Author

FernandoAscencio commented Mar 2, 2023

@FernandoAscencio Before I merge this PR, do you mind rebasing your PR onto the latest master? Just to confirm that your changes aren't the reason that the Ubuntu build pipeline is failing.

Should be done

Closes eclipse-theia#11979

Signed-off-by: FernandoAScencio <fernando.ascencio.cama@ericsson.com>
@msujew msujew merged commit 58248ac into eclipse-theia:master Mar 9, 2023
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
@vince-fugnitto vince-fugnitto added the monaco issues related to monaco label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuickInput is not picking the first element as a fallback on Enter
3 participants