Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: pin ts plugins #12212

Merged
merged 1 commit into from
Feb 23, 2023
Merged

repo: pin ts plugins #12212

merged 1 commit into from
Feb 23, 2023

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Feb 23, 2023 •
edited
Loading

What it does

The commit pins the version of typescript plugins used as builtins in the repository due to an issue when modifying contents of the file. The source of the bug still needs to be investigated further when we upgrade again.

The issue results in newlines (enter) producing odd output:

ts-bug.mp4

How to test

  1. start the application and open a ts file
  2. language features, syntax highlighting should work as expected
  3. add newlines to a ts file, the content should be as expected

Review checklist

Reminder for reviewers

@vince-fugnitto
repo: pin ts plugins
ce92d66 
The commit pins the version of typescript plugins used as builtins in
the repository due to an issue when modifying contents of the file. The
source of the bug still needs to be investigated further when we upgrade
again.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added typescript issues related to the typescript language builtins Issues related to VS Code builtin extensions labels Feb 23, 2023
marcdumais-work
marcdumais-work approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally and the weird issue is not present.

@vince-fugnitto vince-fugnitto merged commit 2f287df into master Feb 23, 2023
@vince-fugnitto vince-fugnitto deleted the vf/pin-ts-plugins branch February 23, 2023 17:38
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 23, 2023
@gbodeen gbodeen mentioned this pull request Feb 24, 2023
Merged
1 task
This was referenced Mar 22, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcdumais-work marcdumais-work marcdumais-work approved these changes

Assignees
No one assigned
Labels
builtins Issues related to VS Code builtin extensions typescript issues related to the typescript language
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @marcdumais-work