terminal: Spawning Speed issue fix #12225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit closed the issue eclipse-theia#1733. Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
vince-fugnitto
approved these changes
Feb 27, 2023
kenneth-marut-work
pushed a commit
to kenneth-marut-work/theia
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #1733.
The pull-request fixes an issue where if multiple terminals are spawned quickly, their content would incorrectly be rendered in a previous terminal. The issue is related to the
createdoption which would not take into account milliseconds which meant calls togetOrCreateWidgetwould return a previous widget rather than create a new one as intended.How to test
Review checklist
Reminder for reviewers