-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Rename command resolves with FileStat #12278
[Workspace] Rename command resolves with FileStat #12278
Conversation
2f78e82
to
923cac4
Compare
cc @kittaakos |
Thanks for the fix. I checked out 923cac4 and verified it with the electron example app.
Interesting way to verify the changeset 🙃 I see the URI in the notification with 923cac4. I cannot reproduce the 12278.mp4 |
@kittaakos |
Verified. Thank you! 12278.mp4 |
923cac4
to
370be95
Compare
The testing commit has been dropped for merging. |
This commit closes eclipse-theia#12101. Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
370be95
to
fda1dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- confirmed that the
rename
command works as expected for files and folders - confirmed that the stat is returned on successful renames
What it does
Closes #12101
Rename command now resolves with
FileStatWithMetadata
on success andundefined
when not.How to test
The second commit includes changes for testing.
Test: File Rename
in the context menuReview checklist
Reminder for reviewers