Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove invasive split terminal action #12358

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

rschnekenbu
Copy link
Contributor

What it does

Partially removes some intrusive split terminal actions in views

Current situtation:
terminal-split

fix #12357

Contributed on behalf of STMicroelectronics

How to test

To test in theia:

  • Check that by default, split terminal action does not appear on toolbars for various views.
  • Check that on terminal views, the split terminal icon is still present when the terminal view is active
  • terminal context menu still displays the split terminal entry

Limitations: when a terminal is active, there are still some polluting split terminal entries on some views.

terminal-split-after

Review checklist

Reminder for reviewers

@tsmaeder
Copy link
Contributor

@rschnekenbu since I don't have write access to the branch, you'll have to rebase on master, @rschnekenbu

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 29, 2023

@rschnekenbu and now the signed-off-by header, please.

@tsmaeder
Copy link
Contributor

Sorry, it's not the signature, seems to be a problem with the dependencies.

@tsmaeder
Copy link
Contributor

@rschnekenbu now the PR needs another lift to master. If you "allow edits by maintainers" on the PR, I could just push the button.

Contributed on behalf of STMicroelectronics
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and test OK for me.

@tsmaeder tsmaeder merged commit 6cd4223 into eclipse-theia:master Mar 29, 2023
@rschnekenbu rschnekenbu deleted the rs/split-terminal branch March 29, 2023 12:44
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
@vince-fugnitto vince-fugnitto added the terminal issues related to the terminal label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove invasive Split Terminal action in the toolbars
3 participants