Add ${targetPlatform} placeholder for plugin downloads #12410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
changed the title
msujew
added
plug-in system
msujew
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Apart from what Mark wrote, I think the feature is a little hidden at this time, can we update https://github.com/eclipse-theia/theia/tree/master/dev-packages/cli#downloading-plugins to provide some information on the feature for end-users?
|
updated the readme to document the feature |
msujew
reviewed
Apr 13, 2023
jonah-iden
force-pushed
the
jiden/target-placeholder-plugin-download-url
branch
from
795613c to
b5f256a
Compare
msujew
approved these changes
Apr 17, 2023
in plugin download urls Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
use regex escape lib, use record, updated README for new feature Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
jonah-iden
force-pushed
the
jiden/target-placeholder-plugin-download-url
branch
from
b5f256a to
00c64c9
Compare
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Dec 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This allows the usage of placeholders in plugin urls for the
theia download:pluginstask. Specificly adds the ${targetPlatform} placeholder to download non universal plugins by the bundling machines operating system and cpu arcitecture.usage looks like this:
How to test
"rust-analyzer": "https://open-vsx.org/api/rust-lang/rust-analyzer/${targetPlatform}/0.4.1473/file/rust-lang.rust-analyzer-0.4.1473@${targetPlatform}.vsix"to your theiaPluginsrust-analyzerplugin in thepluginsfolder is using the correct system binary.Review checklist
Reminder for reviewers