Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: add High Contrast Dark theme missing tab markers #12448

Merged
merged 1 commit into from
May 24, 2023
Merged

Themes: add High Contrast Dark theme missing tab markers #12448

merged 1 commit into from
May 24, 2023

Conversation

FernandoAscencio
Copy link
Contributor

What it does

Implements the following features in the High Contrast Dark theme:

  • The missing active border marker in the sidepanel
  • The dotted selected tab marker in inactive tab groups
  • The missing selected tab marker in the bottom-content-panel.

Before:
HighContrastIssue

After:
HighContrastFix01

How to test

  1. Run Theia
  2. Change theme to High Contrast Dark
  3. Check if the selected sidepanel tab has the active border marker.

Review checklist

Reminder for reviewers

@FernandoAscencio
themes: add HC Dark theme missing markers
f181a8d 
Implements the following features in the High Contrast Dark theme:
- The missing active border marker in the sidepanel
- The dotted selected tab marker in inactive tab groups
- The selected tab marker in the bottom-content-panel.

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vince-fugnitto vince-fugnitto modified the milestone: 1.37.0 Apr 27, 2023
@FernandoAscencio FernandoAscencio changed the title Themes: add Hight Contrast Dark theme missing tab markers Themes: add High Contrast Dark theme missing tab markers May 9, 2023
@vince-fugnitto vince-fugnitto requested a review from msujew May 17, 2023 15:51
@vince-fugnitto vince-fugnitto added theming issues related to theming ui/ux issues related to user interface / user experience labels May 17, 2023
msujew
msujew approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew merged commit 87bc890 into eclipse-theia:master May 24, 2023
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
theming issues related to theming ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FernandoAscencio @msujew @vince-fugnitto