Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition when editor tabs scroll bar needs to be updated #12477

Merged
merged 1 commit into from
May 2, 2023

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented May 2, 2023

What it does

Fixes #12476

Contributed on behalf of STMicroelectronics

How to test

See the scenario in the linked issue.

Review checklist

Reminder for reviewers

Fixes eclipse-theia#12476

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested a review from vince-fugnitto May 2, 2023 10:06
@tsmaeder tsmaeder mentioned this pull request May 2, 2023
1 task
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Confirmed that the changes work as expected.

@tsmaeder tsmaeder merged commit b6de884 into eclipse-theia:master May 2, 2023
@tsmaeder tsmaeder mentioned this pull request May 2, 2023
1 task
@tsmaeder tsmaeder mentioned this pull request May 11, 2023
11 tasks
tsmaeder added a commit to tsmaeder/theia that referenced this pull request May 23, 2023
…e-theia#12477)

Fixes eclipse-theia#12476

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor tab scrollbar not adjusted when closing editors
2 participants