Stub for proposed API: ExternalUriOpener #12539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsan09
added
vscode
This change enables the use of the `Simple Browser` extension in the context of `vscode` API v1.77.x. This is accomplished by stubbing missing `vscode` proposed API i.e. ExternalUriOpener Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09
force-pushed
the
asl/Stub_ExternalUriOpener
branch
from
467c6c2 to
1e9871c
Compare
|
Hi @vince-fugnitto, both of your comments were applied and the branch was re-based to the current master, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12523
This change enables the use of the
Simple Browserextension in the context ofvscodeAPI v1.77.x.This is accomplished by stubbing missing
vscodeproposed API i.e.ExternalUriOpenerHow to test
vscode.simple-browser(previous builtin version to 1.77.2) from the thetheiaplugins folderzipfile inside yourpluginsfolder (this is the 1.77.2 version of the simple-browser plugin built from sources).simple-browser.zip
theiaand from the command palette execute the commandSimple Browser: Show)-> on the input box enter the following site:
https://xkcd.com/NOTE: This browser may not work for many sites, but that's a separate issue to follow up after the true implementation of this stubbed API.
See the following video clip:
https://github.com/eclipse-theia/theia/assets/76971376/d11e012d-106d-4512-a5e6-729571c896a4
Review checklist
Reminder for reviewers