Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator: fix hidden toolbar icons when resizing #12617

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

vladarama
Copy link
Contributor

What it does

This PR fixes #12602 by changing the styling of the explorer to make sure that the toolbar icons are always visible and that the folder name has an ellipsis overflow when the width of the Explorer is limited.

Demo:
Demo

How to test

  • Open a folder with a long name
  • Resize the Explorer view, reducing its width
  • Toolbar icons should be visible and the folder name should have an ellipsis overflow

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me 👍

I'm not a big fan of the !important annotation, but it seems like that's an issue inherited from the perfect-scrollbar dependency and we cannot do a lot about that.

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jun 13, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Confirmed that toolbar items in headers have priority over the title which is a better user-experience.

@vince-fugnitto vince-fugnitto merged commit fbb02df into eclipse-theia:master Jun 13, 2023
@vladarama vladarama deleted the gh-12602-hidden-icons branch June 14, 2023 19:40
@pisv
Copy link
Contributor

pisv commented Jun 15, 2023

I'm sorry for being late to the party, but I'd like to note that there has already been a pending PR for essentially the same issue: #12542. It is based on a slightly different approach and does not use the overflow: visible !important; style. Feel free to close it if is no longer relevant.

@vince-fugnitto vince-fugnitto added this to the 1.39.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

navigator: header hides toolbar icons
4 participants