Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result navigation with next and previous focus #12714

Closed
wants to merge 4 commits into from

Conversation

shynxe
Copy link

@shynxe shynxe commented Jul 15, 2023

What it does

Implementation for issue: #12692

Added commands for Search: Focus Next Search Result and Search: Focus Previous Search Result, similar to their VSCode counterparts, along with the corresponding keybinds.

How to test

  1. Run Theia.
  2. Search using terms which return multiple results.
  3. Use the command palette (Ctrl+Shift+P) and enter Search: Focus Next Search Result (or its Previous counterpart) or using the F4 / Shift+F4 keybinds.
  4. Notice how the results are focused correspondingly.

Review checklist

Reminder for reviewers

@shynxe shynxe changed the title Search result navigation Search result navigation with next and previous focus Jul 15, 2023
@msujew
Copy link
Member

msujew commented Jul 15, 2023

@shynxe Thank you for your contribution. FYI we already have a PR on this issue (though it wasn't linked), see #12703. We'll need to see which one we'll continue to review/merge.

@shynxe
Copy link
Author

shynxe commented Jul 15, 2023

@shynxe Thank you for your contribution. FYI we already have a PR on this issue (though it wasn't linked), see #12703. We'll need to see which one we'll continue to review/merge.

I just noticed that now while I was scrolling through other PRs. Fortunately, this solution is not completely useless, as it covers edge cases which the other one doesn't, such as automatically expanding the FileNode of the focused LineNode in the results view.

@vince-fugnitto
Copy link
Member

@shynxe thank you for taking the time to contribute! We'll go ahead with #12703 for the time being and update it as needed since it is still under review. There are a couple of issues with this implementation at the moment and reviewing the same feature in multiple pull-requests takes time. Thank you for understanding!

@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants