Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Add proposed documentPaste API #12737

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[vscode] Add proposed documentPaste API #12737

merged 1 commit into from
Jul 25, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 20, 2023

What it does

Closes #12633

Updates our theia.proposed.documentPaste.d.ts file to vscode 1.79.0 and ensures that the values from the constructor calls are stored as expected on the DocumentPasteEdit class. Since we don't have any implementation for this vscode API right now, no behavior has changed.

How to test

Nothing to test, no behavior has changed. CI should be green though.

Review checklist

Reminder for reviewers

@msujew msujew added the vscode issues related to VSCode compatibility label Jul 20, 2023
@JonasHelming JonasHelming requested a review from tsmaeder July 21, 2023 07:43
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is entirely non-functional. If it compiles, it's fine.

@msujew msujew merged commit 4093531 into master Jul 25, 2023
@msujew msujew deleted the msujew/documentPaste branch July 25, 2023 13:12
@github-actions github-actions bot added this to the 1.40.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode][proposed] documentPaste proposed API updates for 1.79
2 participants