getting-started: add welcome page checkbox preference #12750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/getting-started/src/browser/getting-started-preferences.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-preferences.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-frontend-module.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-widget.tsx
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-widget.tsx
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-widget.tsx
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-contribution.ts
Outdated
Show resolved
Hide resolved
vince-fugnitto
added
the
getting-started
packages/getting-started/src/browser/getting-started-contribution.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-preferences.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-preferences.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-preferences.ts
Outdated
Show resolved
Hide resolved
packages/getting-started/src/browser/getting-started-contribution.ts
Outdated
Show resolved
Hide resolved
vince-fugnitto
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
LGTM 👍
| Preference | Workspace Opened? | File Opened? | Expected | Actual |
|---|---|---|---|---|
true |
yes | yes | no welcome page on startup |
no welcome page on startup |
true |
yes | no | welcome page on startup |
welcome page on startup |
true |
no | no | welcome page on startup |
welcome page on startup |
true |
no | yes | no welcome page on startup |
no welcome page on startup |
false |
yes | yes | no welcome page on startup |
no welcome page on startup |
false |
yes | no | no welcome page on startup |
no welcome page on startup |
false |
no | no | no welcome page on startup |
no welcome page on startup |
false |
no | yes | no welcome page on startup |
no welcome page on startup |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: eclipse-theia/theia-blueprint#286 and partially eclipse-theia/theia-blueprint#280
This PR adds a preference
Show Welcome Page after every start of the applicationto the welcome page as a checkbox. It also addresses a few points from this issue: eclipse-theia/theia-blueprint#280, by calling itWelcomeinstead ofGet Startedand by making the preference section's UI standout.How to test
Show Welcome page after every start of the applicationand close the welcome page editorReview checklist
Reminder for reviewers