A VS Code extension configurationDefault does not work #12713 #12758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12713
The solution is based on the existing implementation for providing language specific editor settings:
#3540
#4296
In the existing solution we are using a special
defaultOverrides
PreferenceSchema that gets registered. I've adapted the registration code to also work for existing preference keys when provided via this special schema.I am open for suggestions to implement this in a different way, however we should probably refactor the language specific editor overrides then as well.
How to test
See the bug report for a reproducer: #12713
Check the preference's (default) value when installing/uninstalling the extension.
Check the preference UI (default highlight in drop down) and test resetting to the default value
Please be aware of this bug during testing with the vsix from the reproducer: #10812
Review checklist
Reminder for reviewers