Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we keep task type and properly support custom execution #12770

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at martin-fleck-at commented Jul 27, 2023

What it does

  • Make TaskProviderAdapter more resilient against undefined
  • Ensure task type is not lost during conversion (used for custom exec)
  • Ensure task type is considered during comparison

Fixes #12721

How to test

  • Checkout https://github.com/eclipse-theia/theia/tree/martin-fleck-at/12721-test which adds some example tasks to Theia
  • Launch the application using launch configuration 'Launch Electron Backend' (as it sets the plugin directory correctly)
  • F1 > Hello from plugin-a (activates plugin)
  • F1 > Run Task... > mytasktype
  • Execute the shell, process and custom task to see if they are working as expected

Review checklist

Reminder for reviewers

- Make TaskProviderAdapter more resilient against undefined
- Ensure task type is not lost during conversion (used for custom exec)
- Ensure task type is considered during comparison

Fixes #12721
@vince-fugnitto vince-fugnitto added tasks issues related to the task system vscode issues related to VSCode compatibility labels Aug 1, 2023
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!
I've tested with the TaskProvider from your branch.

@martin-fleck-at
Copy link
Contributor Author

@vince-fugnitto @msujew @tsmaeder Does anybody want to have another look at this before we merge it?

@tsmaeder
Copy link
Contributor

If it's good enought for @jfaltermeier, it's good enough for me.

@martin-fleck-at martin-fleck-at merged commit f75c9a2 into master Aug 10, 2023
@martin-fleck-at martin-fleck-at deleted the martin-fleck-at/12721 branch August 10, 2023 08:11
@github-actions github-actions bot added this to the 1.41.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

task created from task definition contributed from VS Code extension throws exception
4 participants