Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle trash dependency helpers in backend #12797

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Bundle trash dependency helpers in backend #12797

merged 1 commit into from
Aug 22, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 2, 2023

What it does

Closes #12780

Bundles the native executables (macos-trash and windows-trash.exe) with the backend so that the executables can actually be executed.

How to test

  1. Start the application on Mac or Windows
  2. Ensure that the Enable Trash setting is enabled
  3. Delete a file. Assert that it has been moved to the trash and no error occurs.

Review checklist

Reminder for reviewers

@msujew msujew added the filesystem issues related to the filesystem label Aug 2, 2023
kittaakos
kittaakos approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. Thank you!

I verified a3432bf with the electron example on macOS.

@msujew msujew requested a review from vince-fugnitto August 17, 2023 12:42
vince-fugnitto
vince-fugnitto approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the trash deletion works as expected on macOS 👍

@msujew msujew merged commit 628d6d2 into master Aug 22, 2023
@msujew msujew deleted the msujew/bundle-trash branch August 22, 2023 13:56
@github-actions github-actions bot added this to the 1.41.0 milestone Aug 22, 2023
This was referenced Nov 27, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
filesystem issues related to the filesystem
Projects
PR Backlog
Archived in project
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

Theia Blueprint fails to delete file to the trash
3 participants
@msujew @kittaakos @vince-fugnitto