Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VS Code tree view checkbox API. #12836

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

tsmaeder
Copy link
Contributor

What it does

Implements the ability to have check boxes on tree views in plugins

Fixes #12695

Contributed on behalf of STMicroelectronics

How to test

Install the attached VS Code extension. It contributes a a view called "Checkbox API Test". Open the view if necessary. Play around with checking/unchecking the checkboxes. The system automatically checks/unchecks parent and child checkboxes: see the VS Code doc linked in the issue for details.
The extension also contributes a preference "Manage Checkbox State Manually". When this preference is on, the automatic checking/unchecking is disabled. The extensions writes to the log, when it is notified of checkbox state changes. There is also a context menu action to check/uncheck the tree items programmatically.

Review checklist

Reminder for reviewers

@tsmaeder tsmaeder requested a review from msujew August 16, 2023 08:45
@tsmaeder
Copy link
Contributor Author

Here's the vsix:

checkboxapi-0.0.1.zip

and the source lives here:

https://github.com/tsmaeder/checkboxapi/

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder force-pushed the 12695_checkbox_tree branch from 77bbeb9 to f862476 Compare August 16, 2023 13:31
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking quite good 👍

  • The API is marked as supported in the comparator report
  • The checkbox rendering works as expected
  • Changing the preference sets the checkboxes into manual mode (requires reload of the plugin after changing the preference)

I have two minor comments below. Should be good to go afterwards 👍

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Aug 18, 2023
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder merged commit 1890fbc into eclipse-theia:master Aug 24, 2023
@tsmaeder
Copy link
Contributor Author

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Support Tree checkbox API
3 participants