-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement VS Code tree view checkbox API. #12836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the vsix: and the source lives here: |
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12695_checkbox_tree
branch
from
August 16, 2023 13:31
77bbeb9
to
f862476
Compare
msujew
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking quite good 👍
- The API is marked as supported in the comparator report
- The checkbox rendering works as expected
- Changing the preference sets the checkboxes into manual mode (requires reload of the plugin after changing the preference)
I have two minor comments below. Should be good to go afterwards 👍
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Thanks for the review. |
1 task
This was referenced Nov 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implements the ability to have check boxes on tree views in plugins
Fixes #12695
Contributed on behalf of STMicroelectronics
How to test
Install the attached VS Code extension. It contributes a a view called "Checkbox API Test". Open the view if necessary. Play around with checking/unchecking the checkboxes. The system automatically checks/unchecks parent and child checkboxes: see the VS Code doc linked in the issue for details.
The extension also contributes a preference "Manage Checkbox State Manually". When this preference is on, the automatic checking/unchecking is disabled. The extensions writes to the log, when it is notified of checkbox state changes. There is also a context menu action to check/uncheck the tree items programmatically.
Review checklist
Reminder for reviewers