Add smoke test for production build #12965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't seem to have any automated test that verifies whether the production build works as expected. For a recent issue and its root cause, which remained unrevealed by the CI, see eclipse-theia#12962 Contributed on behalf of STMicroelectronics Change-Id: Ia2fdb54873344e5d0da12522441a649b6b90bdac
1 task
|
@msujew Sorry for the ping, do you have time to review this change? If not, let me know. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Currently we don't seem to have any automated test that verifies whether the production build works as expected.
For a recent issue and its root cause, which remained unrevealed by the CI, see #12962.
With this PR, we add a new Github workflow, which builds the example browser app in production mode and runs a simple smoke test. This smoke test just opens the app and awaits the loading spinner to disappear and expects the workbench to be visible within a certain timeframe.
Contributed on behalf of STMicroelectronics
How to test
The check should be green after #12964 is merged.
Follow-ups
None
Review checklist
Reminder for reviewers