Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scope API on env var collections #12999

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tsmaeder
Copy link
Contributor

What it does

Implements the EnvironmentVariableScope on the GlobalEnvironmentVariableCollectoin class in the VS Code API.

Fixes #12940

Contributed on behalf of STMicroelectronics

How to test

  1. Install the attached plugin.
  2. Open a workspace with two roots
  3. Start a terminal, chose any root as the cwd
  4. Print out the environment variables. Note that there is no variable called ROOT_MUTATED.
  5. Run the command "Hello World". It activates the extensions
  6. Open a terminal on the first workspace root
  7. Print out the environment variables, not that there are not the env vars ROOT_MUTATED, PERSISTENT_MUTATED and MUTATED2 present
  8. Open a terminal on the second workspace roo
  9. Print out the environment variables. Note that there is only the variable called ROOT_MUTATED present.

Follow-ups

Review checklist

Reminder for reviewers

@tsmaeder
Copy link
Contributor Author

Here is the extension:
envscopetest-0.0.1.zip

And here's the source:
envscopetest.zip

@tortmayr tortmayr removed the request for review from jfaltermeier October 13, 2023 13:51
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and the API is now inline with its VS Code Counterpart.
Tested with the extension as described and everything works as expected (Ubuntu 22.04).

There are some merge conflicts that need to be resolved but other than that LGTM 👍🏼

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder force-pushed the 12940_env_var_scope branch from 913108b to 480d1e2 Compare October 24, 2023 12:06
@tsmaeder tsmaeder requested a review from tortmayr October 24, 2023 12:12
@tsmaeder
Copy link
Contributor Author

@tortmayr I rebased the branch

Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and works as expected!

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder merged commit 0572983 into eclipse-theia:master Oct 24, 2023
12 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.43.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Support EnvironmentVariableScope in vscode API 1.82
3 participants