Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent task terminal title from being changed by task process #13003

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Prevent task terminal title from being changed by task process #13003

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7f97aa
Fix task terminal title changing
bryanchenmchp Oct 16, 2023
7012e3b
Update CHANGELOG.md
bryanchenmchp Oct 16, 2023
e756ac8
Merge branch 'master' into bryanchenmchp/task-terminal-fix-title
bryanchenmchp Oct 23, 2023
b4933b3
Merge branch 'master' into bryanchenmchp/task-terminal-fix-title
bryanchenmchp Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

## v1.43.0 - Unreleased

- [task] prevent task widget title from being changed by task process [#13003](https://github.com/eclipse-theia/theia/pull/13003)
- [vscode] evolve proposed API for dropDocument [#13009](https://github.com/eclipse-theia/theia/pull/13009) - contributed on behalf of STMicroelectronics
- [vscode] evolve proposed API for documentPaste (stubbed) [#13010](https://github.com/eclipse-theia/theia/pull/13010) - contributed on behalf of STMicroelectronics
- [vscode] evolve proposed API for terminalQuickFixProvider [#13006](https://github.com/eclipse-theia/theia/pull/13006) - contributed on behalf of STMicroelectronics
Expand Down
3 changes: 2 additions & 1 deletion packages/task/src/browser/task-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,8 @@ export class TaskService implements TaskConfigurationClient {
title: taskInfo
? `Task: ${taskInfo.config.label}`
: `Task: #${taskId}`,
destroyTermOnClose: true
destroyTermOnClose: true,
useServerTitle: false
}, {
widgetOptions: { area: 'bottom' },
mode: widgetOpenMode,
Expand Down
Loading