fix: omit proxy path prefix from socket.io base path

[bvenreply]

What it does

Fixes an issue causing socket.io to use the wrong basepath when accessing the backend from a reverse proxy. #13055

How to test

This can be tested by running the browser example and accessing via a local nginx proxy:

• Build/run the browser example with yarn && yarn browser build && yarn browser start (Theia will run on port 3000)
• Run nginx using the following nginx.conf

  http {
      server { 
          listen 3300;
  
          location ~* /proxy/(.*)? {
              proxy_set_header Host $host;
              proxy_set_header X-Real-IP $remote_addr;
              proxy_set_header X-Forwarded-For $remote_addr;
              proxy_set_header Upgrade $http_upgrade;
              proxy_set_header Connection "Upgrade";
              proxy_ssl_verify off;
  
              if ($args) {
                  proxy_pass http://127.0.0.1:3000/$1?$args;
              }
  
              proxy_pass http://127.0.0.1:3000/$1;
          }
      }
  }
  events {}

• Access theia via http://localhost:3300/proxy/

Follow-ups

Nothing major that i can see.

The first path argument here is now redundant; probably not really worth worrying about considering the severity of the issue.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Thanks, looks good to me. Seems like my recent changes in #12618 accidentally broke this.

[msujew]

Before we can merge, you'll need to sign the Eclipse Contributor Agreement (ECA) though. Please do that with the same email that was used to create the commit.

[bvenreply]

Before we can merge, you'll need to sign the Eclipse Contributor Agreement (ECA) though. Please do that with the same email that was used to create the commit.

Done @msujew

[msujew]

@bvenreply Seems like the ECA validation still doesn't go through. Have you signed the ECA with benia@protonmail.com? That is the email associated with the commit.

[bvenreply]

@msujew I have:

Is the revalidation usually instant?

[msujew]

Not instant, but it's weird it's taking that long. We'll probably see tomorrow ¯\_(ツ)_/¯

[msujew]

I force pushed on your branch to fix the ECA check. For some reason it didn't work without a new commit. I'll merge this once the CI passes.