Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SiW result line styling #13071

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Nov 9, 2023

What it does

This PR fixes a minor visual regression that was most likely introduced with #12868, where search result lines do not grow to full width and action buttons therefore do not get aligned on the right side.

Here's a comparison.

BeforeAfter

How to test

Follow-ups

Review checklist

Reminder for reviewers

@msujew msujew added search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Nov 9, 2023
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍🏼
The buttons are now correctly aligned on the right side.

@tortmayr tortmayr merged commit 6d1feca into eclipse-theia:master Nov 13, 2023
11 of 12 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.44.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants