Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notebook error logging #13256

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Improve notebook error logging #13256

merged 1 commit into from
Jan 16, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 10, 2024

What it does

I recently had to debug an issue in a production environment, in which the notebook kernel selection didn't "stick". You could select a kernel, but it wouldn't actually apply. The kernel selection silently threw an error in that case. This change adds a console error in case this happens.

How to test

The changes should be pretty self-evident. However, you can test whether

  1. Open a new (untrusted) workspace.
  2. Set the security.workspace.trust.startupPrompt preference to never.
  3. Open a jupyter notebook and select a kernel. An error should be logged into the console.

Review checklist

Reminder for reviewers

@msujew msujew added logging issues related to logging notebook issues related to notebooks labels Jan 10, 2024
@msujew msujew requested a review from jonah-iden January 10, 2024 13:07
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly for me

@JonasHelming
Copy link
Contributor

@msujew I guess you can merge this

@msujew msujew merged commit 3569baa into master Jan 16, 2024
14 checks passed
@msujew msujew deleted the msujew/log-notebook-failures branch January 16, 2024 13:05
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging issues related to logging notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants