Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle activeCustomEditorId (#13219) #13267

Merged

Conversation

dhuebner
Copy link
Member

@dhuebner dhuebner commented Jan 12, 2024

What it does

Tracks activeCustomEditorId context key next to existing activeWebviewPanelId

How to test

It is a bit tricky to test it manually and I found no test spec to re-use to test context keys.

  • To test it manually checkout custom editor sample.
  • Change the catCustoms.pawDraw.new command contribution by adding "enablement": "activeCustomEditorId == 'catCustoms.catScratch'"
  • build the extension using vsce package. Note: You will need to change the publisher in the package json to something meaningful.
  • install cat-customs-0.0.1.vsix into Theia
  • create a file named test.cscratch and open it
  • A command CMD+Shift+P Create new Paw Draw Document should only be visible when the cscratch custom editor is active

Review checklist

Reminder for reviewers

@dhuebner dhuebner marked this pull request as ready for review January 12, 2024 14:33
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me!

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@msujew msujew added vscode issues related to VSCode compatibility custom-editor issues related to custom-editor functionality labels Jan 18, 2024
@msujew msujew merged commit f4ad0cd into eclipse-theia:master Jan 18, 2024
13 of 14 checks passed
@dhuebner dhuebner deleted the huebner/active-custom-editor-13219 branch January 18, 2024 12:25
@msujew msujew linked an issue Jan 18, 2024 that may be closed by this pull request
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-editor issues related to custom-editor functionality vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Handle activeCustomEditorId vs activeWebviewPanelId
4 participants