Fix rending of quickpick buttons

[tortmayr]

What it does

Ensure that the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

More context:
The buttons property is assigned in the QuickOpenMainImpl. This works perfectly fine when creating a InputBox via the quickopen service but for the normal QuickPick
this assignment gets lost because the actual monaco quickpick item is wrapped and the buttons property assignment is not forwarded.

Fixes #13076

Contributed on behalf of STMicroelectronics

How to test

Follow the steps to reproduced described in #13076 (comment)
(vsix for testing is provided).
After installling the plugins., execute the Hello World command. Notice that buttons are now properly rendered (while not being rendered at all on master)

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

The typing here is not right: there is no "buttons" property on QuickPick. Returning monaco-specific types here is not appropriate. QuickPick is a wrapper around IQuickPick.

[tortmayr]

So how should we handle this?
The current implementation in the quick-open-main does not do any type checks at all. It simply iterates through the "params" (of type TransferQuickPick) list and assigns them as property of the input element.

So basically we would have to make sure that all properties of the TransferQuickPick are present on the wrapper and properly forwared to the underyling monaco specific element.
Note: Ignore that statement, seems like I have misinterpreted the code everything should work as expected here.

On a sidenote: There is also a wrapper for MonacoQuickInput which seems currently unused. Thats why the buttons works when using QuickInput` because in that case we use the monaco type directly.
We should probably also wrap that correctly ore remove this class altogether

[tsmaeder]

Add the buttons types readonly QuickInputButton[] to the QuickPick interface and fix the typing by appropriately casting/converting.
Which wraper is unused? Can you explain, please?

[tortmayr]

@tsmaeder

Unfortunatley the QuickInputButton and Monacos IQuickInputButton interface are not compatible.
They use different URI types for the iconPath:

• QuickInputButton: import from 'vscode-uri';
• IQuickInputButton: import from '@theia/monaco-editor/lib/vs/base/common/uri`

They difference is the UriComponent definition which has partial optional properties in the monaco variant

export interface UriComponents {
	scheme: string;
	authority?: string;
	path?: string;
	query?: string;
	fragment?: string;
}

but has no optional properties in the vscode-uri variant:

export interface UriComponents {
    scheme: string;
    authority: string;
    path: string;
    query: string;
    fragment: string;
}

Any ideas how to fix this without leaking monaco-internal types into the QuickInputButton definition?

[tsmaeder]

Can't you just cast the relevant structures? The values are not changed by the cast anyway.

[tortmayr]

👍🏼 done

[JonasHelming]

@tortmayr