Fix race condition in notebook kernel association #13364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
There's a race condition in the notebook kernel association code. Whenever you open a notebook, Theia will automatically try to associate a kernel to it. However, if this notification arrives in the plugin host before the notebook open notification arrives, it will not be able to associate the kernel to the notebook - this effectively disables all cell execution for the specific notebook.
How to test
The issue can be fairly reliably reproduced by:
Previously, notebook cells weren't executing afterwards. This change should alleviate that issue.
Review checklist
Reminder for reviewers