Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce '--install-plugin' cli command. #13421

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Feb 26, 2024

What it does

Fixes #13406

Adds a cli command inspired by the VS Code --install-extension command. Users can give the option multiple times with either a plugin id of the form publisher.name[@version] or with a file path designating a *.vsix file.

contributed on behalf of STMicroelectronics

How to test

Test giving the '--install-extension' and '--install-plugin' command with multiple combinations of plugins files and plugin ids/versions. Make sure the plugins are properly installed and can be uninstalled.

Follow-ups

Review checklist

Reminder for reviewers

Inspired by the VS Code --install-extension command. Users can give the
option multiple times with either a plugin id of the form
"publisher.name[@Version]" or with a file path designating a *.vsix
file.

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested a review from rschnekenbu February 26, 2024 15:24
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could test on a variety of local vsix files and open-vsx extensions, that worked perfectly.
Code looks good to me also.

@tsmaeder tsmaeder merged commit 627dad4 into eclipse-theia:master Feb 28, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add command to install plugins from the command line
3 participants