Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reflect-metadata for git locator-host, build git-locator-host for… #13487

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

fanyipin
Copy link
Contributor

@fanyipin fanyipin commented Mar 13, 2024

… commonjs

Fix git process exception

How to test

Follow-ups

  • add @theia/git package
  • yarn start
  • init git
  • watch git diff files in git widget

Review checklist

Reminder for reviewers

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. I can confirm that this fixes the issue:
Peek 2024-03-19 12-05

@fanyipin
Copy link
Contributor Author

fanyipin commented Mar 20, 2024

Thank you for the fix. I can confirm that this fixes the issue:

Thank you for the approval! I look forward to contributing more to this project in the future

@jfaltermeier jfaltermeier merged commit 44fbdb0 into eclipse-theia:master Mar 20, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants