Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed notebook document metadata edit and added execute cells above/below commands #13528

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Mar 26, 2024

What it does

This does two things:

  1. it fixes the document metadata edits and adds the workspace bulk edit api for notebooks. This allows the run by line command to be shown (there is no debugging support yet for notebooks, so this menu entry has no functionality yet)
  2. this adds the execute cell above and execute cell and below commands to the notebook cell toolbar

(also removes the notebook debug menu entry since its not supported currently)

How to test

Open a notebook and add a few code cells.
Select a cell and click the ... in the toolbar. After granting workspace trust the run by line command should be available.
Execute both execute cell above and execute cell and below commands and see the cells should executed correctly according to the command

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from jbicker March 26, 2024 14:06
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good!

@jonah-iden jonah-iden merged commit 02acd2e into master Mar 28, 2024
13 of 14 checks passed
@jonah-iden jonah-iden deleted the jiden/document-metadata-edit-and-execute-by-line branch March 28, 2024 07:38
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 28, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants