Always consider the "passthrough" commmand enabled for keybindings #13564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Theia has a "passthrough" command that is supposed to mark occasions where keystrokes are supposed to be passed to the target widget instead of being handled by the keybinding infrastructure. We recently added a check whether a keybinding has an enabled command handler to be considered active. But since the "passthrough" command has no handler, it was always considered disabled. This PR considers the passthrough command as always enabled.
Fixes #13560
Contributed on behalf of STMicroelectronics
How to test
Make sure
ctrl-c
aborts running tasks in the terminal. Make sure ctrl-c still works to copy text/files, etc elsewhere.Follow-ups
Review checklist
Reminder for reviewers