Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable clear all outputs in notebook main toolbar #13569

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This disables the clear all outputs command in the notebook main toolbar when no outputs are available in the notebook.

How to test

Open or create a new notebook. Execute cells and clear the outputs. Depending on if there are outputs in the notebook the clear all output option should be enabled or disabled

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
when no outputs are available

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 5, 2024 09:33
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me 👍

Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
@jonah-iden jonah-iden merged commit bce99c2 into master Apr 5, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/disable-clear-all-outputs branch April 5, 2024 12:44
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 5, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants