Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notebook cell context key handling #13572

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

just a small fix to not change the execute button for each cell when only executing one

How to test

Open a notebook and add multiple code cells. Execute one cell, the other cells execute icons should not be affected, only the the executed cell should show the cancel icon

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 8, 2024 10:11
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to a regression regarding the Execute Cells Below/Above commands in the toolbar:

image

They are not visible anymore.

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 10, 2024 09:49
@msujew msujew changed the title fixed all play buttons changing when executing single cell Improve notebook cell context key handling Apr 10, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@jonah-iden jonah-iden merged commit 3da5b6b into master Apr 10, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/notebook-fixes branch April 10, 2024 10:45
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants