Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force notebook scrollbar update after content change #13575

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 8, 2024

What it does

Forces the scrollbar that hosts the notebook widget to update after the content has changed.

This is relevant when the user has used the Clear All Outputs command while the widget is scrolled to the end of the content. In this case the scrollbar was effectively after the content. Updating the scrollbar ensures that the scrollbar doesn't allow scrolling outside of the content.

How to test

  1. Create a notebook document that has large outputs
  2. Scroll to the end of the widget
  3. Run the Clear All Output command
  4. Ensure that the document is still visible

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Apr 8, 2024
@msujew msujew requested a review from jonah-iden April 8, 2024 14:27
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@msujew msujew merged commit 84fdd75 into master Apr 10, 2024
14 checks passed
@msujew msujew deleted the msujew/update-after-clear branch April 10, 2024 07:54
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants