Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open editor on file upload #13578

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Open editor on file upload #13578

merged 1 commit into from
Apr 10, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 9, 2024

What it does

When uploading a file to vscode web, the app automatically opens the newly uploaded file in an editor.
It also does this when overriding a file, replacing the current editor content, even if it's dirty.

This change aligns Theia to vscode's behavior and also opens the uploaded file. It first closes all widgets for this file and then reopens the editor.

How to test

  1. Open a file in your workspace (text/code file or notebook)
  2. Overwrite it with a different file (but same name) by uploading via the navigator widget (or use the Upload Files... command in the context menu of the navigator)
  3. Confirm that the file is correctly updated (if it was open) or newly opened (if it wasn't previously)

Review checklist

Reminder for reviewers

@msujew msujew added filesystem issues related to the filesystem ui/ux issues related to user interface / user experience labels Apr 9, 2024
@msujew msujew requested a review from jonah-iden April 9, 2024 10:11
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM

@msujew msujew merged commit 4ec5655 into master Apr 10, 2024
14 checks passed
@msujew msujew deleted the msujew/open-file-on-upload branch April 10, 2024 10:25
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants