Fix notebook model/cell disposal #13606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Previously, when deleting a cell or a whole notebook, the deletion wasn't propagated to the documents-ext handler. Meaning that there was still a virtual document available in the plugin host for non-existing cell. This later on led to caching issues, for example accidentally executing outdated code cells.
Furthermore, closed notebooks didn't dispose their underlying model when the editor was closed. The model was always available in memory.
This change fixes the notebook document removal event and also simply deletes all cell documents from the plugin host.
How to test
Review checklist
Reminder for reviewers