working notebook cell language select #13615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing notebook enter in notebook cell editors Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
jonah-iden
force-pushed
the
jiden/notebook-cell-language-select
branch
from
9eb3432 to
2b1d91f
Compare
msujew
reviewed
Apr 18, 2024
packages/editor/src/browser/editor-language-quick-pick-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
|
@msujew it works fine for me at least for all cells except the first. But the reason for that seems to be a bigger one. Seems like the preferred cell language is not set correctly by the extensions. Havn't figured out why yet |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
|
@msujew forget that i found the culprit. Should work now. At least it does for me |
msujew
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This allows clicking the language on the bottom right of notebook cells and change the cell language.
For this it moves some of the editor-command code to select a code language to its own service
Also fixes a small but pretty substantial problem with notebook cells and not being able to create new lines when pressing enter
How to test
Open a notebook.
Create a multi line cell check that enter works correctly
Click on the language tag in the lower right corner of the cell and change the language
Follow-ups
Review checklist
Reminder for reviewers