Stub TestCoverage API #13631
Stub TestCoverage API #13631
Conversation
|
@rschnekenbu we should at least have a test plugin that exercises the stubbed code: extensions should at least not crash when they call the API. |
| constructor(public name: string, public executed: number | boolean, public location: Position | Range) { } | ||
| } | ||
| @es5ClassCompat | ||
| export class TestCoverageCount implements theia.TestCoverageCount { |
There was a problem hiding this comment.
theia.TestCoverageCount is not an interface. Why the "implements"?
There was a problem hiding this comment.
I removed this declaration, that indeed makes no sense.
| } | ||
|
|
||
| export namespace StatementCoverage { | ||
| export function is(coverage: unknown): coverage is StatementCoverage { |
There was a problem hiding this comment.
Wouldn't instanceof work just as well, since this is a class?
There was a problem hiding this comment.
Good catch, I removed this namespace addition in favor of a instanceof.
|
I addressed the review comments in a following patch. To run the extension:
Here is the behavior on vscode 1.88: And on theia browser example: |
contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/13549-stub
branch
from
37769aa to
6fd0939
Compare
What it does
Stub the new API introduced with vscode 1.88 about TestCoverage. This was previously a proposed API.
Fixes #13549
Contributed on behalf of STMicroelectronics
How to test
I did not have a testing plugin yet, as usual plugins used for testing are not implementing the coverage API. For example, Playwright does not yet implement code coverage as seen here: microsoft/playwright#30298.
Follow-ups
Implement TestCoverage API. This will be tracked as a task of #12010.
Review checklist
Reminder for reviewers