Support proposed API registerMappedEditsProvider2 introduced in vscode 1.94 #14276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 1.94 fixes eclipse-theia#14268 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/14268
branch
from
f907939 to
f842af9
Compare
|
I wrote a Pull Request to run the build for the builtins version 1.94 here: eclipse-theia/vscode-builtin-extensions#132. This is still a draft, as I cannot fully test by myself (I am not yet aware of the publishing steps for example). This can help producing the builtins 1.94.0 to test the API compatibility. |
tsmaeder
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR updates the proposed API mappedEditProviders to support vscode 1.94 evolutions. This API was already stubbed in a previous PR (see #13681)
fixes #14268
contributed on behalf of STMicroelectronics
How to test
Build and install typescript builtin. It relies on this proposed API, but not on the new API. Builtins shall start and work without any issues.
Follow-ups
None
Review checklist
Reminder for reviewers