-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai): Improve agent history recording #14378
feat(ai): Improve agent history recording #14378
Conversation
* Simplify recording for chat requests/responses by providing a util * Introduce explicit optional system message field * Show messages and system message in history view as a context * A few minor typos and nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, it is a shame how often I misspelled Orchestrator :-)
I believe the Orchestrator and the Terminal Assistant do not list the messages in the context, is this expected?
On a fresh start, when the history is not open, the drop down of the history view is empty and I get this error when clicking it. Not sure, whether this is related to your change, though, probably rather to: #14236
root ERROR The above error occurred in the component:
at SelectComponent (http://127.0.0.1:3000/bundle.js:342317:9)
at div
Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.
I have to reload to recover from this.
One question: Why do you use the fork, it would be simple to create a branch in the Theia repo. |
@JonasHelming Thank you for your feedback! Right, the Orchestrator didn't include the messages, even though they are technically part of the context. So I added it. The react error is unrelated imho, but I pushed a fix for it too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
What it does
How to test
Use all agents and check whether their history:
Follow-ups
None
Review checklist
Reminder for reviewers