Update Inversify to latest

[msujew]

What it does

Closes #14431.

The latest minor version of Inversify (6.1.0) introduced some behavior changes with regards to injected base classes. Inversify validates that the constructor arguments are in some way satisfied (by asserting constructor function length). Since we sometimes use an inheritance pattern that breaks this assertion, this leads to runtime failures in newer versions of Inversify.

This change adds @unmanaged() decorations to all constructors that aren't injected. Also adds a few more type constraints during compile time where Inversify got more strict in its typing.

How to test

Assert that the CI is green, and the application builds and runs without any start error.

Follow-ups

I couldn't really find all places where we're using the above mentioned pattern, as I couldn't find a way to easily search for it.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[sdirix]

I was able to build and start the browser application and did not encounter any error just by clicking a bit around and trying some features.

I then checked with the regex @injectable(.|\n)*?constructor to find all places where an @unmanaged might be needed.

I found the following @injectable classes which either have constructor parameters which are neither injected nor are declared unmanaged or execute a super call to a parent class without such declarations for their parameters.

• AbstractDialog
• AbstractTreeDecoratorService
• BaseWidget
• BlameDecorator
• MarkerTree
• HostedPlugin
• ProxyPluginDeployerEntry
• AbstractHostedPluginSupport
• Process
• Task
• DefaultTerminalProfileService

[msujew]

@sdirix Thanks for looking into this! I've added the decorations for the listed classes :)

[sdirix]

Works for me! Thanks for the work!

[tsmaeder]

What's keeping this PR from being merged?