feat(ai): agents can ask for input and continue #14486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow custom chat agents to stop completing the response conditionally * Introduce an orthogonal response state called `waitingForInput` * Introduce `show` setting on progress messages to control visibility * 'untilFirstContent': Disappears when first response content appears * 'whileIncomplete': Remains visible while response is incomplete * 'forever': Remains visible forever. * Adds a `QuestionResponseContent` and `QuestionPartRenderer` * Adds an API example agent 'AskAndContinue' that uses these features * Introduces agent-specific content matchers (in contrast to globals) * Dels redundant response completion & recording in `AbstractChatAgent` Contributed on behalf of STMicroelectronics.
sdirix
requested changes
Nov 26, 2024
examples/api-samples/src/browser/chat/ask-and-continue-chat-agent-contribution.ts
Outdated
Show resolved
Hide resolved
examples/api-samples/src/browser/chat/ask-and-continue-chat-agent-contribution.ts
Show resolved
Hide resolved
examples/api-samples/src/browser/chat/ask-and-continue-chat-agent-contribution.ts
Outdated
Show resolved
Hide resolved
sdirix
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
waitingForInputshowsetting on progress messages to control visibilityQuestionResponseContentandQuestionPartRendererAbstractChatAgentContributed on behalf of STMicroelectronics.
How to test
You can test all features with the
@AskAndContinueexample agent.AskAndContinue.mp4
Follow-ups
None
Review checklist
Reminder for reviewers