Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min height to cell outputs #14488

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

Adds a min height to cell outputs so that when an output rendering is smaller than that it does not move all the other outputs

How to test

create a cell that does render a too small output. For example i used

import plotly.express as px
import pandas as pd
df =pd.DataFrame({'col1': [1, 2], 'col2': [3, 4]})
px.scatter_mapbox(df, 'col1', 'col2')

create simple code cells below it like print('test').
Execute all cells and validate that the text outputs are not moved into their cell editors space

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew November 20, 2024 14:14
@jonah-iden jonah-iden marked this pull request as draft November 20, 2024 15:05
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden marked this pull request as ready for review November 20, 2024 15:10
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added the notebook issues related to notebooks label Nov 21, 2024
@jonah-iden jonah-iden merged commit 6cebf4a into master Nov 21, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/add-min-height-to-cell-outputs branch November 21, 2024 12:57
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants