Cancel pending hover on mouse exit #14533
Conversation
There was a problem hiding this comment.
I like this change!
I found one edge/case issue: When switching fast and often between two hoverable elements, I sometimes can reproduce that no more tooltip appears although I'm hovering an element. Once the mouse leaves and enters again the tooltip will reappear.
The behavior is better than the status quo with the weird delayed tooltips, so I would be fine with a merge.
There was a problem hiding this comment.
Actually I noticed one more issue:
Previously it was possible to be quick enough to enter the tooltip with the mouse to copy its contents. This is no longer possible.
- Is this a worthwhile feature?
- Do we want to keep it?
In this Gif we can see the current state of master with the
- weird delay of tooltips showing although the element is no longer hovered
- the ability to enter and copy the tooltip content
|
@tsmaeder any preference on your side for today's release and/or followups? |
|
I don't think this is a critical problem, so let's not force it in if it's not ready. |
I'm certainly not in such a hurry, so I wouldn't ask for it to make this release 😀
This is something that I actually do quite a lot in other tools (some don't support selection in tool-tips, others do). I think I should be able to preserve this capability with a judicious sprinkling of debounces or similar. I'll give it a go. |
|
Commit ecf3c2d restores mouse pointer access to the hover pop-up itself and also fixes other glitches. |
|
@sdirix would you like to take another look? |
If the mouse exits before the HoverService has rendered its pop-up, cancel the pending presentation of that pop-up. Also fix the problem of it being difficult to mouse over to the pop-up itself after it is shown to interact with it (it being necessary to carefully track over the bottom triangle). This is accomplished by cancelling only after a short delay that allows the mouse to reach either the pop-up or the original hover target. Fixes eclipse-theia#14532 Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
|
Commit 56cfe5d takes a much simpler approach to fix both the problem of quick mouse fly-overs popping up the hover widget and also the difficulty of mousing over to the hover pop-up once it's shown. |
What it does
If the mouse exits before the HoverService has rendered its pop-up, cancel the pending presentation of that pop-up.
Fixes #14532.
How to test
Pass the mouse pointer quickly over items in the status bar that provide hover pop-ups. See that those pop-ups do not appear when the mouse pointer has already gone elsewhere. Verify that the pop-up behaves as before when the mouse pointer lingers on the target element. Both cases as captured here in a screen recording:
Follow-ups
None.
Review checklist
Reminder for reviewers