Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Anthropic as an LLM provider #14614

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Support Anthropic as an LLM provider #14614

merged 3 commits into from
Dec 13, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #14613

What it does

Adds support for Anthropic as an LLM provider.

How to test

Use Anthropic models.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming requested a review from sdirix December 11, 2024 13:42
@JonasHelming JonasHelming self-assigned this Dec 11, 2024
@JonasHelming
Copy link
Contributor Author

@sdirix Tool functions do not work yet. That is probably in the way how they are parsed from the stream, but I have no clue how that works for openai TBH, maybe you can have a quick look at this.

@JonasHelming
Copy link
Contributor Author

3PP Check was approved, should succeed with the next rebuild

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anthropic works for me, I tested with streaming enabled and disabled.

I also had a look at the tools. The issue is that in our OpenAI language models we directly hand over real Javascript functions into the API which are used by the OpenAI client to resolve the tools, see here.

Anthropic seemingly does not support this but instead expects a new message from the "user", see the first example here.

Suggestion: For the first implementation we skip the tool support and add this in a followup. Of course feel free to add it here too if you want to see it supported.

jbicker and others added 3 commits December 12, 2024 22:51
fixed #14613

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@JonasHelming JonasHelming merged commit f11c19a into master Dec 13, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Theia AI] Support Anthropic as an LLM provider
3 participants