Fix for #14615: "Collapse Side Panel" tab bar context menu item is enabled even when panel is collapsed #14616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when panel is collapsed
martin-fleck-at
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Hi @sophiali23, great catch! I reviewed your change and it works perfectly. Thank you for your contribution - it truly helps improve the overall user experience, highly appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #14615. "Collapse Side Panel" tab bar context menu item is enabled even when side panel is collapsed. My fix will disable the context menu item if the panel is not expanded.
How to test
Attribution
Contributed on behalf of Texas Instruments
Review checklist
Reminder for reviewers