Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes deleting cell outputs or cells with outputs while there are invisible cells.
How to test
Best way to test is probably adding something like
to the getVisibleCells method of the
NotebookModel
. Then opening the notebook with the text editor and add"hidden":true
to the metadata.Then open the notebook normally and test moving and deleting cells and outputs.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers