Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for invisible cells #14617

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fixes for invisible cells #14617

merged 1 commit into from
Dec 12, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Fixes deleting cell outputs or cells with outputs while there are invisible cells.

How to test

Best way to test is probably adding something like

        return this.cells.filter(cell => !(cell.metadata.custom as { metadata: { hidden: boolean } })?.metadata?.hidden);

to the getVisibleCells method of the NotebookModel. Then opening the notebook with the text editor and add "hidden":true to the metadata.

Then open the notebook normally and test moving and deleting cells and outputs.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew December 12, 2024 11:59
@msujew msujew added the notebook issues related to notebooks label Dec 12, 2024
@jonah-iden jonah-iden merged commit 04dfd9b into master Dec 12, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/invisible-cell-fixes branch December 12, 2024 12:11
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants